Change in vdsm[master]: Enable balloon and use the MoM multiple policies feature

msivak at redhat.com msivak at redhat.com
Tue Jul 16 08:03:24 UTC 2013


Martin Sivák has posted comments on this change.

Change subject: Enable balloon and use the MoM multiple policies feature
......................................................................


Patch Set 4: (4 inline comments)

....................................................
File vdsm/Makefile.am
Line 115: 	mom.conf.in \
Line 116: 	mom.d/03-ksm.policy \
Line 117: 	mom.d/02-balloon.policy \
Line 118: 	mom.d/01-parameters.policy \
Line 119: 	mom.d/00-python.policy \
Done
Line 120: 	sourceRoute.sh \
Line 121: 	sudoers.vdsm.in \
Line 122: 	supervdsmd.init.in \
Line 123: 	supervdsmd.service.in \


Line 231: 		$(DESTDIR)$(vdsmconfdir)/mom.d/01-parameters.policy
Line 232: 	$(INSTALL_DATA) mom.d/02-balloon.policy \
Line 233: 		$(DESTDIR)$(vdsmconfdir)/mom.d/02-balloon.policy
Line 234: 	$(INSTALL_DATA) mom.d/03-ksm.policy \
Line 235: 		$(DESTDIR)$(vdsmconfdir)/mom.d/03-ksm.policy
Done
Line 236: 	$(INSTALL_DATA) mom.conf \
Line 237: 		$(DESTDIR)$(vdsmconfdir)/mom.conf
Line 238: 
Line 239: uninstall-data-mom:


....................................................
File vdsm.spec.in
Line 826: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/logger.conf
Line 827: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/svdsm.logger.conf
Line 828: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/mom.conf
Line 829: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/mom.d/00-python.policy
Line 830: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/mom.d/01-parameters.policy
Well I would prefer to give the admin a chance of modifying it. We can't anticipate all user cases.
Line 831: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/mom.d/02-balloon.policy
Line 832: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/mom.d/03-ksm.policy
Line 833: %config(noreplace) %{_sysconfdir}/logrotate.d/vdsm
Line 834: %config(noreplace) %{_sysconfdir}/rwtab.d/vdsm


Line 828: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/mom.conf
Line 829: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/mom.d/00-python.policy
Line 830: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/mom.d/01-parameters.policy
Line 831: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/mom.d/02-balloon.policy
Line 832: %config(noreplace) %{_sysconfdir}/%{vdsm_name}/mom.d/03-ksm.policy
Done
Line 833: %config(noreplace) %{_sysconfdir}/logrotate.d/vdsm
Line 834: %config(noreplace) %{_sysconfdir}/rwtab.d/vdsm
Line 835: %config(noreplace) %{_sysconfdir}/sysctl.d/vdsm
Line 836: %if 0%{?with_systemd}


-- 
To view, visit http://gerrit.ovirt.org/16728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3fa80990bdbcd88f8ec83f5c664047c75c2e7a73
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list