Change in vdsm[master]: Add setMOMPolicyParameters
danken at redhat.com
danken at redhat.com
Mon Jul 15 17:57:07 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: Add setMOMPolicyParameters
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
minor comment/question. all-and-all, I prefer the usage of setPolicyParameters over setPolicy.
....................................................
File vdsm/momIF.py
Line 38:
Line 39:
Line 40: class MomThread(threading.Thread):
Line 41:
Line 42: def __init__(self, momconf, mominstance=None):
is there an existing motivation for this change? is it really part of the content of this patch?
Line 43: if not _momAvailable:
Line 44: raise MomNotAvailableError()
Line 45:
Line 46: self.log = logging.getLogger("MOM")
--
To view, visit http://gerrit.ovirt.org/16659
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2c2fce24a8a499976ef845ce1e7e40bdd439949
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list