Change in vdsm[master]: Multiple Gateways[6/2]: Swapped libvirt network & netEnt cre...

danken at redhat.com danken at redhat.com
Mon Jul 15 08:54:47 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Multiple Gateways[6/2]: Swapped libvirt network & netEnt creation
......................................................................


Patch Set 8: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm/sourceRoute.py
Line 102:     @staticmethod
Line 103:     def addInterfaceTracking(device):
Line 104:         _, _, _, bootproto, _ = device.getIpConfig()
Line 105:         if bootproto == 'dhcp':
Line 106:             open(DynamicSourceRoute.getTrackingFilePath(device.name), 'a').\
Well, I usually like the implicit close()ing of a files (as you cannot forget closing...).

However, your code is equivalent, and it is the least of our problems within this patch.
Line 107:                 close()
Line 108: 
Line 109:     @staticmethod
Line 110:     def removeInterfaceTracking(device):


-- 
To view, visit http://gerrit.ovirt.org/16692
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5af431909427dc7488875f0cb14fe4361657a83
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list