Change in vdsm[master]: vdsmd.init.in: fix some style problems

Alon Bar-Lev alonbl at redhat.com
Sun Jul 14 14:14:07 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: vdsmd.init.in: fix some style problems
......................................................................


Patch Set 1:

> Is it better leave it be and read sysconfig/vdsm ?

I think you can read both... this way we can obsolete the wrong one.

> I thought in http://gerrit.ovirt.org/#/c/14826/7/vdsm/init/init_mkdirs.sh around line 32, your comments was to encourage using a detected path. Am I wrong? Did you mean just to use "mkdir" instead of "/bin/mkdir"?

I always against of using full path for executables, unless there is strict need because of security. But there are people here who like full paths... so I am unsure what to reply.

-- 
To view, visit http://gerrit.ovirt.org/16809
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1efa4b91c96249a28ca40ccdd045864fbb79e316
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list