Change in vdsm[master]: Multiple Gateways[6/2]: Swapped libvirt network & netEnt cre...
amuller at redhat.com
amuller at redhat.com
Sun Jul 14 11:47:40 UTC 2013
Assaf Muller has posted comments on this change.
Change subject: Multiple Gateways[6/2]: Swapped libvirt network & netEnt creation
......................................................................
Patch Set 6: (3 inline comments)
Responded to review comments.
....................................................
File vdsm/sourceRoute.py
Line 32: from vdsm.utils import execCmd
Line 33: from vdsm.utils import CommandPath
Line 34:
Line 35:
Line 36: _TOUCH_BINARY = CommandPath('touch', '/bin/touch')
Done
Line 37: TRACKED_INTERFACES_FOLDER = P_VDSM_RUN + 'trackedInterfaces'
Line 38:
Line 39:
Line 40: class StaticSourceRoute(object):
Line 109:
Line 110: @staticmethod
Line 111: def removeInterfaceTracking(device):
Line 112: try:
Line 113: os.remove(DynamicSourceRoute.getTrackingFilePath(device.name))
Done
Line 114: except:
Line 115: pass
Line 116:
Line 117: @staticmethod
Line 179: self.configurator.removeSourceRoute(
Line 180: self._getRoutes(table, self.device), rules,
Line 181: self.device)
Line 182:
Line 183: def _isLibvirtInterfaceFallback(self):
The commit message states that patch set 4 moved these functions but not why, and to be honest I had not even considered stating that there's no code change... I'm still not in a code-review mindset. In any case, the reason for the move is that these functions are only performed with DynamicSourceRoutes, I don't know why they were originally created in StaticSourceRoute.
Line 184: """
Line 185: Checks whether the device belongs to libvirt when libvirt is not yet
Line 186: running (network.service runs before libvirtd is started). To do so,
Line 187: it must check if there is an autostart network that uses the device.
--
To view, visit http://gerrit.ovirt.org/16692
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5af431909427dc7488875f0cb14fe4361657a83
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list