Change in vdsm[master]: Multiple Gateways[5/2]: Iproute2 handles exceptions

danken at redhat.com danken at redhat.com
Sat Jul 13 09:51:12 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Multiple Gateways[5/2]: Iproute2 handles exceptions
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

Swallowing an exception is a bad practice. If ever, it has to be done at the caller of the function. Or at least explain why all users of the method do not care if it succeeds or fails.

....................................................
File vdsm/netconf/iproute2.py
Line 35:                 routeAdd(route)
Line 36: 
Line 37:             for rule in rules:
Line 38:                 ruleAdd(rule)
Line 39:         except IPRoute2Error as e:
exc_info=true usually prints e.message. I believe that the whole "as e" can be dropped.
Line 40:             logging.error('Error in configureSourceRoute: %s' % e.message,
Line 41:                           exc_info=True)
Line 42: 
Line 43:     @staticmethod


-- 
To view, visit http://gerrit.ovirt.org/16629
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib550a63257de28df1c44a92aeb0dc078f2edd906
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list