Change in vdsm[master]: Multiple Gateways[6/2]: Swapped libvirt network & netEnt cre...

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Thu Jul 11 13:22:28 UTC 2013


Mark Wu has posted comments on this change.

Change subject: Multiple Gateways[6/2]: Swapped libvirt network & netEnt creation
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/sourceRouteThread.py
Line 34:                 sourceRoute.configure(ip, mask, gateway)
Line 35:             else:
Line 36:                 sourceRoute.remove()
Line 37: 
Line 38:             sourceRoute.removeVDSMInterfaceTracking()
Could you please consider this solution?
 1.  create the tracking file during addNetwork.  2. log some marker to the tracking file during delNetwork.  3. check the marker when responding to the DHCP reply,  if it has, delete tracking file, otherwise leave the tracking file
Line 39: 
Line 40:         os.remove(sourceRouteFilePath)
Line 41: 
Line 42:     def process_IN_CLOSE_WRITE(self, event):


-- 
To view, visit http://gerrit.ovirt.org/16692
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5af431909427dc7488875f0cb14fe4361657a83
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list