Change in vdsm[master]: Multiple Gateways[4/2]: Fixed ifdown bug for DHCP interfaces

amuller at redhat.com amuller at redhat.com
Mon Jul 8 20:33:59 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: Multiple Gateways[4/2]: Fixed ifdown bug for DHCP interfaces
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File lib/vdsm/ipwrapper.py
Line 161:         if source == 'all':
Line 162:             source = None
Line 163:         if destination == 'all':
Line 164:             destination = None
Line 165:         srcDevice = data.get('dev') or data.get('iif')
I don't understand why, but when invoking 'ip rule add...' you must use 'dev'. Using iif will get an error. However, when when using 'ip rule' to display the rules, they are displayed with iif.

That's why in __str__ I (must) use dev. We use __str__ to be able to use 'ip rule del', and that command must accept the rule with 'dev' and not 'iif'. We use fromText to parse rules from 'ip rule' output - So we must use data.get('iif'). If I am not mistaken data.get('dev') isn't used right now, but obviously I want to be able to parse rules that are output from our own __str__.
Line 166: 
Line 167:         return cls(table, source=source, destination=destination,
Line 168:                    srcDevice=srcDevice)
Line 169: 


-- 
To view, visit http://gerrit.ovirt.org/16552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1ed9efc548ec0342db9ea0ae4692d2c0aec93df
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <giuseppe at openquake.org>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list