Change in vdsm[master]: Decoupling libvirtconnection.py from clintIF.py

danken at redhat.com danken at redhat.com
Mon Jul 8 12:16:33 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Decoupling libvirtconnection.py from clintIF.py
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(2 inline comments)

minor textual comments.

....................................................
Commit Message
Line 3: AuthorDate: 2013-07-01 15:33:37 +0300
Line 4: Commit:     Mooli Tayer <mtayer at redhat.com>
Line 5: CommitDate: 2013-07-08 14:43:25 +0300
Line 6: 
Line 7: Decoupling libvirtconnection.py from clintIF.py
clint -> client
Line 8: 
Line 9: 1.) Decoupling libvirtconnection.py from clientIF.py
Line 10: adding libvirt cb handlers for vm events belongs in vm.py
Line 11: 2.) bugfix: not all libviryconnecition.get() invocations


....................................................
File lib/vdsm/libvirtconnection.py
Line 63: 
Line 64: def get(target=None, killOnFailure=True):
Line 65:     """Return current connection to libvirt or open a new one.
Line 66:     Use target to get/create the connection object linked to that object.
Line 67:     If target has a callable attribute named 'dispatchLibvirtEvents' it
docstring should be fixed, too.
Line 68:     will be registered as a callback on libvirt events.
Line 69: 
Line 70:     Wrap methods of connection object so that they catch disconnection, and
Line 71:     take the current process down.


-- 
To view, visit http://gerrit.ovirt.org/16393
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc550ea40ebb3abcf37ebfa59cbf8df8e42daa96
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list