Change in vdsm[master]: ifcfg: Do not reconfigure existing underlaying device for VL...

mhuntxu at gmail.com mhuntxu at gmail.com
Fri Jul 5 10:43:43 UTC 2013


Hunt Xu has posted comments on this change.

Change subject: ifcfg: Do not reconfigure existing underlaying device for VLANs
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/netconf/ifcfg.py
Line 142: 
Line 143:     def removeVlan(self, vlan):
Line 144:         ifdown(vlan.name)
Line 145:         self._removeSourceRoute(vlan)
Line 146:         self.configWriter.removeVlan(vlan.name)
The user of a vlan could only be a bridge in a bridged network, and that user would be removed before this function is called. So I think a checking here is not needed. But I'm not that sure, correct me if I miss something.
Line 147: 
Line 148:     def _ifaceDownAndCleanup(self, iface, _netinfo):
Line 149:         """Returns True iff the iface is to be removed."""
Line 150:         ifdown(iface.name)


-- 
To view, visit http://gerrit.ovirt.org/16474
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a0738c32aefd6eca7fd094ad6f51d8a07353bb2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list