Change in vdsm[master]: Hidden bonds[2/2]: Refactored and updated nics implementatio...
gvallare at redhat.com
gvallare at redhat.com
Thu Jul 4 13:31:01 UTC 2013
Giuseppe Vallarelli has posted comments on this change.
Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
......................................................................
Patch Set 8: (2 inline comments)
....................................................
File lib/vdsm/config.py.in
Line 66: ('hidden_nics', 'wlan*,usb*',
Line 67: 'Comma-separated list of fnmatch-patterns for host nics to be '
Line 68: 'hidden from vdsm.'),
Line 69:
Line 70: ('hidden_bonds', 'bond*',
Thanks I wasn't sure of it.
Line 71: 'Comma-separated list of fnmatch-patterns for host bonds to be '
Line 72: 'hidden from vdsm.'),
Line 73:
Line 74: ('default_bridge', 'engine', None),
....................................................
File lib/vdsm/netinfo.py
Line 88:
Line 89: def isHiddenBond(device):
Line 90: return _match_name(device, hidden_bonds)
Line 91:
Line 92: def isNotEnslavedByHiddenBond(device):
Ok!
Line 93: """
Line 94: Returns boolean stating if nic is not enslaved to an hidden bond.
Line 95: """
Line 96: for bond_fn in hidden_bonds:
--
To view, visit http://gerrit.ovirt.org/16239
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieab80a3ca6b243ade75e490b7004bebe96248140
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
More information about the vdsm-patches
mailing list