Change in vdsm[master]: Hidden bonds[2/2]: Refactored and updated nics implementatio...

asegurap at redhat.com asegurap at redhat.com
Thu Jul 4 09:14:37 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Hidden bonds[2/2]: Refactored and updated nics implementation.
......................................................................


Patch Set 7: I would prefer that you didn't submit this

(1 inline comment)

And glob to iglob.

....................................................
File lib/vdsm/netinfo.py
Line 90:         return _match_name(device, hidden_bonds)
Line 91: 
Line 92:     def isNotEnslavedByHiddenBond(device):
Line 93:         """
Line 94:         Returns boolean stating if nic is not enslaved
All the docstring fits in 80 characters.
Line 95:         to an hidden bond.
Line 96:         """
Line 97:         for bond_fn in hidden_bonds:
Line 98:             for bond_path in glob.glob(NET_PATH + '/' + bond_fn):


-- 
To view, visit http://gerrit.ovirt.org/16239
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieab80a3ca6b243ade75e490b7004bebe96248140
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>


More information about the vdsm-patches mailing list