Change in vdsm[master]: Failing to deactivate LVs is a serious issue.

ewarszaw at redhat.com ewarszaw at redhat.com
Wed Jul 3 17:30:45 UTC 2013


Eduardo has uploaded a new change for review.

Change subject: Failing to deactivate LVs is a serious issue.
......................................................................

Failing to deactivate LVs is a serious issue.

Changing volumes that are active in multiple hosts can lead to DC.

Related to BZ#960952.

Change-Id: If9f37dcf90e8169464582bc44dff054def86e3bd
Signed-off-by: Eduardo <ewarszaw at redhat.com>
---
M vdsm/storage/imageRepository/formatConverter.py
1 file changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/16422/1

diff --git a/vdsm/storage/imageRepository/formatConverter.py b/vdsm/storage/imageRepository/formatConverter.py
index e7bf297..da2e2c2 100644
--- a/vdsm/storage/imageRepository/formatConverter.py
+++ b/vdsm/storage/imageRepository/formatConverter.py
@@ -286,12 +286,7 @@
                           exc_info=True)
 
             finally:
-                try:
-                    img.teardown(domain.sdUUID, imgUUID)
-                except:
-                    log.debug("Unable to teardown the image %s, this error is "
-                              "not critical since the volume might be in use",
-                              imgUUID, exc_info=True)
+                img.teardown(domain.sdUUID, imgUUID)
 
         log.debug("Finalizing the storage domain upgrade from version %s to "
                   "version %s for domain %s", currentVersion, targetVersion,


-- 
To view, visit http://gerrit.ovirt.org/16422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9f37dcf90e8169464582bc44dff054def86e3bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>


More information about the vdsm-patches mailing list