Change in vdsm[master]: gluster: verbs for managing services

danken at redhat.com danken at redhat.com
Wed Jul 3 14:18:35 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: gluster: verbs for managing services
......................................................................


Patch Set 23: (1 inline comment)

....................................................
File vdsm/gluster/services.py
Line 127:     return _action(serviceNames, action, failOnError)
Line 128: 
Line 129: 
Line 130: @makePublic
Line 131: def servicesGet(serviceNames, failOnError=False):
but why do you want the two forms of execution? always why returning a list of success/failures is not good enough?
Line 132:     """
Line 133:     {'services': [
Line 134:         {'name': SERVICE_NAME, 'status': STATUS, 'message': MESSAGE},..]}
Line 135:     """


-- 
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list