Change in vdsm[master]: vdsClient: check getFileList arguments

peet at redhat.com peet at redhat.com
Wed Jul 3 09:42:47 UTC 2013


Peter V. Saveliev has uploaded a new change for review.

Change subject: vdsClient: check getFileList arguments
......................................................................

vdsClient: check getFileList arguments

A simple check of getFileList arguments on the function call.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=958878
Signed-off-by: Peter V. Saveliev <peet at redhat.com>
Change-Id: I0519562fd459393a72644b5d4e2045cb77b22746
---
M client/vdsClient.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/16380/1

diff --git a/client/vdsClient.py b/client/vdsClient.py
index 2d7a8de..215ea73 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1107,6 +1107,7 @@
         return 0, ''
 
     def getFileList(self, args):
+        assert args
         validateArgTypes(args, [str, str])
         response = self.s.getFileList(*args)
         if response['status']['code']:
@@ -2483,7 +2484,7 @@
             code = 1
         print message
         sys.exit(code)
-    except (TypeError, IndexError, ValueError) as e:
+    except (TypeError, IndexError, ValueError, AssertionError) as e:
         print "Error using command:", e, "\n"
         print command
         for line in commands[command][1]:


-- 
To view, visit http://gerrit.ovirt.org/16380
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0519562fd459393a72644b5d4e2045cb77b22746
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>


More information about the vdsm-patches mailing list