Change in vdsm[master]: vdsm: [WIP] Reboot capability for VM

vfeenstr at redhat.com vfeenstr at redhat.com
Wed Jul 3 07:16:34 UTC 2013


Vinzenz Feenstra has posted comments on this change.

Change subject: vdsm: [WIP] Reboot capability for VM
......................................................................


Patch Set 5: I would prefer that you didn't submit this

(1 inline comment)

Agreeing with tony on vm.py

....................................................
File vdsm_api/vdsmapi-schema.json
Line 5686: #
Line 5687: # @reboot:   #optional True if reboot is desired, False for shutdown
Line 5688: #
Line 5689: # @force:    #optional True if shutdown/reboot desired by any means necessary
Line 5690: #                     (forceful reboot/shutdown if all graceful methods fail)
Maybe you should document the default of force and reboot is for each False
Line 5691: # Since: 4.10.0
Line 5692: ##
Line 5693: {'command': {'class': 'VM', 'name': 'shutdown'},
Line 5694:  'data': {'vmID': 'UUID', '*delay': 'int', '*message': 'str',


-- 
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list