Change in vdsm[master]: RAM snapshots feature

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Tue Jul 2 15:40:49 UTC 2013


Michal Skrivanek has posted comments on this change.

Change subject: RAM snapshots feature
......................................................................


Patch Set 12: (1 inline comment)

....................................................
File vdsm/vm.py
Line 3584:             # This code should be removed once qemu-img will handle files
Line 3585:             # with size that is not multiple of block size correctly
Line 3586:             if memoryParams:
Line 3587:                 sdUUID = memoryVol['domainID']
Line 3588:                 oop.getProcessPool(sdUUID).fileUtils.write(
If we should differentiate (and i'm not sure about it) we should use oop for all file based storage and not just nfs. I'd prefer consistent behavior if oop is not that much heavy
Line 3589:                     memoryVolPath, '\0' * 512, 'a')
Line 3590: 
Line 3591:             for drive in newDrives.values():  # Update the drive information
Line 3592:                 try:


-- 
To view, visit http://gerrit.ovirt.org/15072
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62401940afb0228cbd9dd3611b6ed8e0ff67c82c
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list