Change in vdsm[master]: vdsmd.init: Add init adapter

ybronhei at redhat.com ybronhei at redhat.com
Tue Jul 2 06:34:36 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsmd.init: Add init adapter
......................................................................


Patch Set 4: (3 inline comments)

....................................................
File vdsm.spec.in
Line 125: Requires: sanlock, sanlock-python
Line 126: Requires: selinux-policy-targeted
Line 127: %else
Line 128: Requires: python
Line 129: Requires: python-argparse
shouldn't be also available in fedora?
Line 130: # Update the qemu-kvm requires when block_stream will be included
Line 131: Requires: qemu-kvm >= 2:0.12.1.2-2.295.el6_3.4
Line 132: Requires: qemu-img >= 2:0.12.1.2-2.295.el6_3.4
Line 133: Requires: libvirt >= 0.10.2-18.el6_4.4


....................................................
File vdsm/vdsmd.init.in
Line 59:     fi
Line 60: 
Line 61:     echo $"Starting up vdsm daemon: "
Line 62: 
Line 63:     NICELEVEL="-20" daemon --user=vdsm "@VDSMDIR@/init/daemonAdapter" \
make -20 a variable value
Line 64: 		-r --respawn-option="--minlifetime,10,--daemon,--masterpid,$RESPAWNPIDFILE" \
Line 65: 		-c /dev/null --vdsm-option="--pidfile=$PIDFILE"
Line 66:     RETVAL=$?
Line 67:     [ "$RETVAL" -eq 0 ] && log_success_msg $"$prog start" || log_failure_msg $"$prog start"


Line 61:     echo $"Starting up vdsm daemon: "
Line 62: 
Line 63:     NICELEVEL="-20" daemon --user=vdsm "@VDSMDIR@/init/daemonAdapter" \
Line 64: 		-r --respawn-option="--minlifetime,10,--daemon,--masterpid,$RESPAWNPIDFILE" \
Line 65: 		-c /dev/null --vdsm-option="--pidfile=$PIDFILE"
avoid tabs
Line 66:     RETVAL=$?
Line 67:     [ "$RETVAL" -eq 0 ] && log_success_msg $"$prog start" || log_failure_msg $"$prog start"
Line 68:     [ "$RETVAL" -eq 0 ] && touch /var/lock/subsys/vdsmd
Line 69: }


-- 
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list