Change in vdsm[master]: Storage Domain V3 Functional Tests

fsimonce at redhat.com fsimonce at redhat.com
Mon Jul 1 13:51:43 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: Storage Domain V3 Functional Tests
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File tests/functional/xmlrpcTests.py
Line 274:                     r['status']['code'], se.StorageDomainDoesNotExist.code)
Line 275: 
Line 276:             r = self.s.createStorageDomain(
Line 277:                 storage.sd.name2type(domain['type']), sdid, domain['name'],
Line 278:                 specificArg, storage.sd.name2class(domain['class']), 3)
Technically it's possible but we don't use them at the moment.
Line 279:             self.assertVdsOK(r)
Line 280:             undo = lambda sdid=sdid: \
Line 281:                 self.assertVdsOK(self.s.formatStorageDomain(sdid, True))
Line 282:             rollback.prependDefer(undo)


-- 
To view, visit http://gerrit.ovirt.org/14829
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf9d918b5ef68eaf75c328a1368d1b8d5198f023
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list