Change in vdsm[master]: Issue when running make rpm in Fedora 18 without root access...

danken at redhat.com danken at redhat.com
Thu Jan 31 18:04:19 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Issue when running make rpm in Fedora 18 without root access.
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

I do wonder why I do not see the problem in my account or via jenkins.

....................................................
Commit Message
Line 5: CommitDate: 2013-01-30 14:47:21 +0200
Line 6: 
Line 7: Issue when running make rpm in Fedora 18 without root access.
Line 8: 
Line 9: The ConfigWriterTests:testPersistantBackup fails, because it uses libvirt's createNetwork and removeNetwork functions, but libvirt requires root access. The current solution is to use monkey patch, and simply nullify the create and remove network functions. The test now passes, but this might not be the ideal solution to the problem.
please break message lines at the 80 char mark
Line 10: 
Line 11: Signed-off-by: Assaf Muller <amuller at redhat.com>


--
To view, visit http://gerrit.ovirt.org/11545
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2e0076e146c57228eee3cca8b57948fb82bcbb7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list