Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...

asegurap at redhat.com asegurap at redhat.com
Wed Jan 30 23:44:19 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged' field
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

The minus one is just for visibility, in case my plea for dropping it instead of NetInfoBridge items )before it settles there) can be heard.

....................................................
File vdsm/netinfo.py
Line 318:                                    'netmask': getnetmask(bridge),
Line 319:                                    'gateway': routes.get(bridge, '0.0.0.0'),
Line 320:                                    'mtu': getMtu(bridge),
Line 321:                                    'cfg': getIfaceCfg(bridge),
Line 322:                                    'bridged': True,
I guess that this addition comes from it being defined in the API, but... Would it be possible not to have it. It feels kind of reduntant to specify that bridges are bridged.
Line 323:                                    })
Line 324:                          for bridge in bridges()])
Line 325: 
Line 326:     d['nics'] = dict([(nic, {'speed': speed(nic),


--
To view, visit http://gerrit.ovirt.org/11567
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dfa57649e545dbdf490fec1bb7bf3012b509a40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list