Change in vdsm[master]: jsonrpc: Rearrange test classes for reusability

danken at redhat.com danken at redhat.com
Wed Jan 30 21:46:31 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: jsonrpc: Rearrange test classes for reusability
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm_api/jsonrpc/client.py
Line 11: try:
Line 12:     import proton
Line 13:     from jsonrpc import protonReactor
Line 14:     proton         # Squash pyflakes error for
Line 15:     protonReactor  # unused import
why is it imported?

If "import protonReactor" fails (after "import proton" succeeds), we would not notice it. So I do not understand the purpose of this.
Line 16: except ImportError:
Line 17:     pass
Line 18: 
Line 19: 


--
To view, visit http://gerrit.ovirt.org/11122
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78f9546c0bfb2348510340922ba95569b1827830
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list