Change in vdsm[master]: shareVolumeRollback() unique call likes to raise on the unex...

ewarszaw at redhat.com ewarszaw at redhat.com
Wed Jan 30 13:03:45 UTC 2013


Eduardo has posted comments on this change.

Change subject: shareVolumeRollback() unique call likes to raise on the unexpected.
......................................................................


Patch Set 2: (2 inline comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-01-27 11:02:13 +0200
Line 4: Commit:     Eduardo Warszawski <ewarszaw at redhat.com>
Line 5: CommitDate: 2013-01-28 10:17:37 +0200
Line 6: 
Line 7: shareVolumeRollback() unique call likes to raise on the unexpected.
Danken liked it. Please suggest a better one.
Line 8: 
Line 9: Looking in to Volume.share() (unique) call to shareVolumeRollback()
Line 10: seems evident that it should raise if the recovery failed.
Line 11: The try blocks removed silently blow cases when the recovery path


Line 9: Looking in to Volume.share() (unique) call to shareVolumeRollback()
Line 10: seems evident that it should raise if the recovery failed.
Line 11: The try blocks removed silently blow cases when the recovery path
Line 12: failed to remove the link (if it exists) because any other reason
Line 13: that an inexistent link; this is clearly unintentional.
I agree. The code explain it better.
The purpose is to remove safeUnlink. See next patches.
Line 14: 
Line 15: Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270


--
To view, visit http://gerrit.ovirt.org/11422
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f01ff2d30ffecc05b9cfd4978f79003a8032270
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list