Change in vdsm[ovirt-3.2]: removing the use of zombie reaper from supervdsm

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Wed Jan 30 01:50:44 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: removing the use of zombie reaper from supervdsm
......................................................................


Patch Set 2:

Hi Yaniv, I see Royce has post a unit test for this case in the mailing list. Then I try to add the following line

 signal.siginterrupt(signal.SIGCHLD, False)

in the zombie reaper implementation right after registering the SIGCHLD handler. This can pass the unit test in Royce's attachment. As Royce's analysis,  the problem is that manager implementation in Python does not retry the interrupted "receive" call. I think maybe we can avoid to interrupt it or can let it restart automatically.

I think we can also use signalfd. When using a signalfd, the targeted signal is blocked using sigprocmask, so it will not interrupt system calls, then another thread can read the signalfd to get the targeted signal which is delivered to the process or to the thread itself. If the signalfd is created with non-blocking mode, we can select/poll on the signalfd for reading. I tried to write a code snippet to experiment signalfd in python as well. Could you have a look? https://gist.github.com/4661516

--
To view, visit http://gerrit.ovirt.org/11491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3f9bae47f2894cc95785de8f19f6ec388ea58da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list