Change in vdsm[master]: clusterlock: add the local locking implementation

danken at redhat.com danken at redhat.com
Mon Jan 28 12:42:40 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: clusterlock: add the local locking implementation
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/storage/clusterlock.py
Line 131: 
Line 132: initSANLockLog = logging.getLogger("initSANLock")
Line 133: 
Line 134: 
Line 135: def initSANLock(sdUUID, idsPath, leasesPath):
do you see anyone doing

 from clusterlock import initSANLock

? I don't, and thus I'd expect it to be called _initSANLock. But this is not important enough to delay this patch any further.
Line 136:     initSANLockLog.debug("Initializing SANLock for domain %s", sdUUID)
Line 137: 
Line 138:     try:
Line 139:         sanlock.init_lockspace(sdUUID, idsPath)


--
To view, visit http://gerrit.ovirt.org/10282
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I106618a9a61cc96727edaf2e3ab043b2ec28ebe1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list