Change in vdsm[master]: Fix mbx Exception type.
danken at redhat.com
danken at redhat.com
Sun Jan 27 16:19:34 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: Fix mbx Exception type.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/storage_mailbox.py
Line 726: # "command: " + str(cmd))
Line 727: (rc, in_mail, err) = misc.execCmd(cmd, sudo=False, raw=True)
Line 728: if rc:
Line 729: raise IOError(errno.EIO, "_handleRequests._checkForMail - "
Line 730: "Could not read mailbox: %s", str(self._inbox))
str() explodes on unicode (simple %s is good)
self._inbox is huge and not deeply related to the error to read from file. Are you not more interested in in_mail ?
(sorry for not noticing these questions earlier)
Line 731:
Line 732: if (len(in_mail) != (self._outMailLen)):
Line 733: self.log.error('SPM_MailMonitor: _checkForMail - dd succeeded '
Line 734: 'but read %d bytes instead of %d, cannot check '
--
To view, visit http://gerrit.ovirt.org/6617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8baf1121aaf351b029945972d5e87dbfa6a0bd5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list