Change in vdsm[master]: Do not fail when getVSize is called on an inactive LV.

danken at redhat.com danken at redhat.com
Thu Jan 24 20:45:12 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Do not fail when getVSize is called on an inactive LV.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

Please rebase on top of current master, as simple cherry-pick would not take it in.

Make sure it builds with no pep8 errors.

....................................................
File vdsm/storage/blockVolume.py
Line 100:             if e.errno == os.errno.ENOENT:
Line 101:                 # Inactive volume has no /dev entry. Fallback to lvm way.
Line 102:                 size = int(int(lvm.getLV(sdobj.sdUUID, volUUID).size) / bs)
Line 103:             else:
Line 104:                 cls.log.warn("Could not get size for vol %s/%s",
I utterly do not understand your insistence to spam the logs here. but if you have acks from others, I won't hold your patch just because of this.

However, you must fix the font of the whitespace in line 105 (indentation).
Line 105:                                 sdobj.sdUUID, volUUID, exc_info=True)
Line 106:                 raise
Line 107: 
Line 108:         return size


--
To view, visit http://gerrit.ovirt.org/9739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8b6da4d57cdf810769586c1959989d7a545d0c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list