Change in vdsm[master]: clusterlock: add the local locking implementation
fsimonce at redhat.com
fsimonce at redhat.com
Thu Jan 24 17:37:59 UTC 2013
Federico Simoncelli has posted comments on this change.
Change subject: clusterlock: add the local locking implementation
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/storage/clusterlock.py
Line 322:
Line 323: lockFile = misc.safe_open(self._idsPath, os.O_RDONLY)
Line 324:
Line 325: try:
Line 326: fcntl.flock(lockFile, fcntl.LOCK_EX | fcntl.LOCK_NB)
We shouldn't be risking starvation using fcntl.LOCK_NB.
Line 327: except IOError as e:
Line 328: misc.safe_close(lockFile)
Line 329: if e.errno in (os.errno.EACCES, os.errno.EAGAIN):
Line 330: raise se.AcquireLockFailure(
--
To view, visit http://gerrit.ovirt.org/10282
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I106618a9a61cc96727edaf2e3ab043b2ec28ebe1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list