Change in vdsm[master]: make misc.pgrep for general usage

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Thu Jan 24 14:25:30 UTC 2013


Mark Wu has posted comments on this change.

Change subject: make misc.pgrep for general usage
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/utils.py
Line 213:         res.append(statline[procNameStart + 1:procNameEnd])
Line 214:         args = statline[procNameEnd + 2:].split()
Line 215:         res.append(args[0])
Line 216:         res.extend([int(item) for item in args[1:]])
Line 217:         # only 44 feilds are documented in man page while /proc/pid/stat has 52
according to kernel code, the other 8 fields are start_data,end_data,start_brk,arg_start,arg_end,env_start,env_end and exit_code. It's the process memory layout and exit_code.  Currently I don't think we need go that far. So the first 44 fields are enough. You could remove the comment.
Line 218:         return stat._make(res[:44])
Line 219: 
Line 220: 
Line 221: class TimedSample:


--
To view, visit http://gerrit.ovirt.org/11033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2034b04a4787d2f222cb98dfe3ffcdbb2a94ebb8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list