Change in vdsm[master]: Simplify ip address validation leveraging socket.

danken at redhat.com danken at redhat.com
Thu Jan 24 09:42:35 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Simplify ip address validation leveraging socket.
......................................................................


Simplify ip address validation leveraging socket.

Currently we have a ad-hoc validation of the validity of ip
addresses. Since the standard socket module has a built-in
validator inside inet_pton, we could leverage it.

Change-Id: I6f43556f092d60160860e813b22fcc8660d82a80
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
---
M vdsm/configNetwork.py
1 file changed, 3 insertions(+), 7 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Mark Wu: Looks good to me, but someone else must approve
  Dan Kenigsberg: 
  Igor Lvovsky: Looks good to me, approved
  Zhou Zheng Sheng: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/11334
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6f43556f092d60160860e813b22fcc8660d82a80
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list