Change in vdsm[master]: Support for GLUSTERFS_DOMAIN

deepakcs at linux.vnet.ibm.com deepakcs at linux.vnet.ibm.com
Thu Jan 24 06:57:33 UTC 2013


Deepak C Shetty has posted comments on this change.

Change subject: Support for GLUSTERFS_DOMAIN
......................................................................


Patch Set 14: (2 inline comments)

@Dan,
   Added few comments to yours. Pls let me know your thoughts, post which I will send next patchset. Thanks.

....................................................
File vdsm/storage/glusterVolume.py
Line 31:         volPort = "0"
Line 32: 
Line 33:         imgFilePath = self.getVolumePath()
Line 34:         imgFilePath_list = imgFilePath.rsplit("/")
Line 35:         imgFileRelPath = "/".join(imgFilePath_list[4:])
Actually getVolumePath returns the path as below ( unlike i put before )...

/rhev/data-center/9d9790c3-3486-4a6e-b6ed-32cfdd1f7d27/6e5c80ef-523b-45c3-a366-28406c4c5daf/images/78abe539-2d20-469b-adf7-8fa753016102/dbf9b95f-22d3-4ccc-aa5e-dbdb988fdb20

So your suggestion to use [-4:] would still work, since we are going from the back of the list. Thanks, i will use ur suggestion and post next patchset.
Line 36: 
Line 37:         glusterPath = volname + '/' + imgFileRelPath
Line 38: 
Line 39:         return {'volType': VmVolumeInfo.TYPE_NETWORK, 'path': glusterPath,


....................................................
File vdsm/storage/storageServer.py
Line 248: class GlusterFSConnection(MountConnection):
Line 249: 
Line 250:     def _getLocalPath(self):
Line 251:         return os.path.join(
Line 252:             self.localPathBase, "glusterSD",
I tried this

class GlusterFSConnection(MountConnection):
    localPathBase = os.path.join(sd.mountBasePath,
                                 "glusterSD")
This needs storageServer.py to do 'import sd'.

I am hoping this is fine & no need to override getLocalPath ? 
This works as I tested.
Line 253:             self._remotePath.replace("_", "__").replace("/", "_"))
Line 254: 
Line 255: 
Line 256: class NFSConnection(object):


--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list