Change in vdsm[master]: Storage: Check that underlying file system supports direct I...

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Thu Jan 24 02:35:49 UTC 2013


Shu Ming has posted comments on this change.

Change subject: Storage: Check that underlying file system supports direct IO
......................................................................


Patch Set 6: No score

(1 inline comment)

....................................................
File vdsm/storage/nfsSD.py
Line 45:         if not mount.isMounted(domPath):
Line 46:             raise se.StorageDomainFSNotMounted(domPath)
Line 47: 
Line 48:         fileSD.validateDirAccess(domPath)
Line 49:         fileSD.validateFileSystemFeatures(sdUUID, domPath)
If the file system doesn't support O_DIERCT, should we allow the FileStorageDomain instantiation continue without O_DIRECT support?
Line 50: 
Line 51:         # Make sure there are no remnants of other domain
Line 52:         mdpat = os.path.join(domPath, "*", sd.DOMAIN_META_DATA)
Line 53:         if len(oop.getProcessPool(sdUUID).glob.glob(mdpat)) > 0:


--
To view, visit http://gerrit.ovirt.org/9749
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf14d1c4737a88e693e5bebb896aef382b8b424c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: humble devassy <hchiramm at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list