Change in vdsm[master]: clusterlock: add the local locking implementation

smizrahi at redhat.com smizrahi at redhat.com
Wed Jan 23 22:37:47 UTC 2013


Saggi Mizrahi has posted comments on this change.

Change subject: clusterlock: add the local locking implementation
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/clusterlock.py
Line 156:         self._sdUUID = sdUUID
Line 157:         self._idsPath = idsPath
Line 158:         self._leasesPath = leasesPath
Line 159:         self._sanlockfd = None
Line 160:         self._initImpl = SANLockInit(sdUUID, idsPath, leasesPath)
Yea my mistake, I reviewed everything at once and got confused
Line 161: 
Line 162:     def initLock(self):
Line 163:         self._initImpl.initLock()
Line 164: 


--
To view, visit http://gerrit.ovirt.org/10282
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I106618a9a61cc96727edaf2e3ab043b2ec28ebe1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list