Change in vdsm[master]: Removing vdsm configuration when removing vdsm service

dougsland at redhat.com dougsland at redhat.com
Wed Jan 23 11:15:33 UTC 2013


Douglas Schilling Landgraf has posted comments on this change.

Change subject: Removing vdsm configuration when removing vdsm service
......................................................................


Patch Set 1:

I would support removing both vdsm conf styles, the new and old one, here an example from vdsmd.init.in

 remove_vdsm_conf() {
        sed -i --copy -e "/${start_conf_section}/,/${end_conf_section}/d" \
            -e "/$by_vdsm/d" "$@"
    }

--
To view, visit http://gerrit.ovirt.org/11295
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f59375e20efa6b5de8483a12a772f5f0ce3749
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list