Change in vdsm[master]: Support for GLUSTERFS_DOMAIN

deepakcs at linux.vnet.ibm.com deepakcs at linux.vnet.ibm.com
Wed Jan 23 11:10:08 UTC 2013


Deepak C Shetty has posted comments on this change.

Change subject: Support for GLUSTERFS_DOMAIN
......................................................................


Patch Set 14: (4 inline comments)

@dan,
   pls see my comments and let me know if I have understood you correctly ?

....................................................
File vdsm/storage/glusterVolume.py
Line 14:         """
Line 15:         Send info to represent Gluster volume as a network block device
Line 16:         """
Line 17:         rpath = sdCache.produce(self.sdUUID).getRemotePath()
Line 18:         rpath_list = rpath.rsplit(":")
Done
Line 19:         volfileServer = rpath_list[0]
Line 20:         volname = rpath_list[1]
Line 21: 
Line 22:         # Volume transport to Libvirt transport mapping


Line 31:         volPort = "0"
Line 32: 
Line 33:         imgFilePath = self.getVolumePath()
Line 34:         imgFilePath_list = imgFilePath.rsplit("/")
Line 35:         imgFileRelPath = "/".join(imgFilePath_list[4:])
Regret if i was not clear. Given the below path for a image as an example :
/rhev/data-center/mnt/glusterSD/vm-vdsm-de-1:dpkvol3/51f3411f-d507-4f78-be9c-96c245eb9273/images/280c372c-9cd5-4fa0-9dbc-238a087a1e9b/b11687e6-978e-42b7-90c3-a4bf77cde1cc

I want to extract :
51f3411f-d507-4f78-be9c-96c245eb9273/images/280c372c-9cd5-4fa0-9dbc-238a087a1e9b/b11687e6-978e-42b7-90c3-a4bf77cde1cc

since thats what is volume relative path which gets fed to qemu's gluster backend.

What do you mean by "do it directly" ? I am not clear.
Line 36: 
Line 37:         glusterPath = volname + '/' + imgFileRelPath
Line 38: 
Line 39:         return {'volType': VmVolumeInfo.TYPE_NETWORK, 'path': glusterPath,


....................................................
File vdsm/storage/sdc.py
Line 140:         # if an nfs mount is unavailable we will get stuck
Line 141:         # until it times out, this should affect fetching
Line 142:         # of block\local domains. If for any case in the future
Line 143:         # this changes, please update the order.
Line 144:         for mod in (blockSD, localFsSD, glusterSD, nfsSD):
Done
Line 145:             try:
Line 146:                 return mod.findDomain(sdUUID)
Line 147:             except se.StorageDomainDoesNotExist:
Line 148:                 pass


....................................................
File vdsm/storage/storageServer.py
Line 248: class GlusterFSConnection(MountConnection):
Line 249: 
Line 250:     def _getLocalPath(self):
Line 251:         return os.path.join(
Line 252:             self.localPathBase, "glusterSD",
So instead of overriding, I can jsut do 
localPathBase = os.path.join(MountConnection.localPathBase, "glusterSD")
inside the GlusterConnection class, is my understanding rite ?
Line 253:             self._remotePath.replace("_", "__").replace("/", "_"))
Line 254: 
Line 255: 
Line 256: class NFSConnection(object):


--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list