Change in vdsm[master]: vdsm: free loop device when umounting floppy in mkimage.py

danken at redhat.com danken at redhat.com
Wed Jan 23 10:11:17 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm: free loop device when umounting floppy in mkimage.py
......................................................................


vdsm: free loop device when umounting floppy in mkimage.py

After umounting floppy successfully, it doesn't free automatically
the loop device. Here, we add the support to free the loop device
in the umount function of Mount class and free it to prevent it
using up all loop devices.

The issue only happened in the special case that node is built using
livecd-tools(version: 16.8-1) and rpms from centos63. Because:
1. Centos63 disables auto-destruction feature and still depends on
   /etc/mtab to free the loop device.
2. Livecd-tools links /etc/mtab to /proc/self/mounts, so umount can't
   get suggestion to free the loop device from /etc/mtab.

Change-Id: Ia02cfaf4d8ba46de6d42b12d15351d3ab1cb3d03
Signed-off-by: jarod.w <work.iec23801 at gmail.com>
---
M vdsm/mkimage.py
M vdsm/storage/mount.py
2 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Hunt Xu: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/11132
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia02cfaf4d8ba46de6d42b12d15351d3ab1cb3d03
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jarod.w <work.iec23801 at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Jarod.w <work.iec23801 at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list