Change in vdsm[master]: Storage: Check that underlying file system supports direct I...
shuming at linux.vnet.ibm.com
shuming at linux.vnet.ibm.com
Tue Jan 22 10:12:58 UTC 2013
Shu Ming has posted comments on this change.
Change subject: Storage: Check that underlying file system supports direct IO
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/fileSD.py
Line 64: def validateFileSystemFeatures(sdUUID, mountDir):
Line 65: try:
Line 66: # Don't unlink this file, we don't have the cluster lock yet as it
Line 67: # requires direct IO which is what we are trying to test for. This
Line 68: # means that unlinking the file might cause a reace. Since we don't
reace--->race.
Line 69: # care what the content of the file is, just that we managed to
Line 70: # open it O_DIRECT.
Line 71: testFilePath = os.path.join(mountDir, "__DIRECT_IO_TEST__")
Line 72: oop.getProcessPool(sdUUID).directTouch(testFilePath)
Line 70: # open it O_DIRECT.
Line 71: testFilePath = os.path.join(mountDir, "__DIRECT_IO_TEST__")
Line 72: oop.getProcessPool(sdUUID).directTouch(testFilePath)
Line 73: except OSError as e:
Line 74: if e.errno == errno.EINVAL:
How about the other errno code threw out by directTouch?
Line 75: log = logging.getLogger("Storage.fileSD")
Line 76: log.error("Underlying file system doesn't support"
Line 77: "direct IO")
Line 78: raise se.StorageDomainTargetUnsupported()
--
To view, visit http://gerrit.ovirt.org/9749
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf14d1c4737a88e693e5bebb896aef382b8b424c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: humble devassy <hchiramm at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list