Change in vdsm[master]: Support for GLUSTERFS_DOMAIN

danken at redhat.com danken at redhat.com
Mon Jan 21 11:36:48 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Support for GLUSTERFS_DOMAIN
......................................................................


Patch Set 14: I would prefer that you didn't submit this

(4 inline comments)

mostly non-lethal stuff, but please address my questions.

....................................................
File vdsm/storage/glusterVolume.py
Line 14:         """
Line 15:         Send info to represent Gluster volume as a network block device
Line 16:         """
Line 17:         rpath = sdCache.produce(self.sdUUID).getRemotePath()
Line 18:         rpath_list = rpath.rsplit(":")
having a verbatim colon in the path is quite insane, but if you are doing rsplit(), you should limit yourself to a single splitter.
Line 19:         volfileServer = rpath_list[0]
Line 20:         volname = rpath_list[1]
Line 21: 
Line 22:         # Volume transport to Libvirt transport mapping


Line 31:         volPort = "0"
Line 32: 
Line 33:         imgFilePath = self.getVolumePath()
Line 34:         imgFilePath_list = imgFilePath.rsplit("/")
Line 35:         imgFileRelPath = "/".join(imgFilePath_list[4:])
where is this hard-coded "4" comes from? shouldn't it depend on @vdsmrepo@?

I'm not sure that what you do is safer than imgFilePath[len(/rhev/data-center):]
Line 36: 
Line 37:         glusterPath = volname + '/' + imgFileRelPath
Line 38: 
Line 39:         return {'volType': VmVolumeInfo.TYPE_NETWORK, 'path': glusterPath,


....................................................
File vdsm/storage/sdc.py
Line 132:     def _findDomain(self, sdUUID):
Line 133:         import blockSD
Line 134:         import localFsSD
Line 135:         import nfsSD
Line 136:         import glusterSD
nit: keep sorted
Line 137: 
Line 138:         # The order is somewhat important, it's ordered
Line 139:         # by how quickly get can find the domain. For instance
Line 140:         # if an nfs mount is unavailable we will get stuck


....................................................
File vdsm/storage/storageServer.py
Line 248: class GlusterFSConnection(MountConnection):
Line 249: 
Line 250:     def _getLocalPath(self):
Line 251:         return os.path.join(
Line 252:             self.localPathBase, "glusterSD",
why not just set localPathBase += '/glusterSD'
Line 253:             self._remotePath.replace("_", "__").replace("/", "_"))
Line 254: 
Line 255: 
Line 256: class NFSConnection(object):


--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list