Change in vdsm[master]: Simplify netinfo get.

asegurap at redhat.com asegurap at redhat.com
Sun Jan 20 10:29:08 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Simplify netinfo get.
......................................................................


Patch Set 9: (2 inline comments)

....................................................
Commit Message
Line 9: This patch refactors netinfo to have the network data fetching on
Line 10: a separate function. This reduces the get() complexity and will
Line 11: allow the possibility of reusing the new method for more fine-
Line 12: grained information retrieval, e.g., update just a network info
Line 13: of a Netinfo instance.
I'm working on a wrapper in a future patch that exposes the functionality in a nicer way?
Line 14: 
Line 15: Change-Id: I5c3e617d10308d0bfa4deaed329b2e10ef54077c


....................................................
File vdsm/netinfo.py
Line 293:                      'mtu': getMtu(iface)})
Line 294:     except OSError as e:
Line 295:         if e.errno == errno.ENOENT:
Line 296:             logging.info('Obtaining info for net %s.', iface, exc_info=True)
Line 297:             raise KeyError('Network %s was not found')
Ooops. Right. I'll fix that. Thanks!
Line 298:         else:
Line 299:             raise
Line 300:     return data
Line 301: 


--
To view, visit http://gerrit.ovirt.org/11080
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c3e617d10308d0bfa4deaed329b2e10ef54077c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list