Change in vdsm[master]: [WIP]wait vdsm instead of poking it

ybronhei at redhat.com ybronhei at redhat.com
Sun Jan 20 09:55:21 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: [WIP]wait vdsm instead of poking it
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File vdsm/supervdsmServer.py
Line 346:     log = logging.getLogger("SuperVdsm.Server")
Line 347:     return log
Line 348: 
Line 349: 
Line 350: def startSvdsm(address, childProc):
call it vdsmProcessHandler
Line 351:     def sigtermHandler(signum, frame):
Line 352:         if childProc.is_alive():
Line 353:             childProc.terminate()
Line 354:             childProc.join()


Line 434: if __name__ == '__main__':
Line 435:     vdsmProc = Process(target=startVdsm)
Line 436:     vdsmProc.start()
Line 437:     sleep(2)
Line 438:     startSvdsm(ADDRESS, vdsmProc)
what about if childProc dies? you need to start it again..


--
To view, visit http://gerrit.ovirt.org/11192
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2067cbd317cebfb7e0ad5aee64788adef591cf6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list