Change in vdsm[master]: migrateStatus() progress report

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Fri Jan 18 13:59:22 UTC 2013


Michal Skrivanek has posted comments on this change.

Change subject: migrateStatus() progress report
......................................................................


Patch Set 16: (1 inline comment)

....................................................
File vdsm/vm.py
Line 1201:     def migrateCancel(self):
Line 1202:         self._acquireCpuLockWithTimeout()
Line 1203:         try:
Line 1204:             self._migrationSourceThread.stop()
Line 1205:             return self._migrationSourceThread.status
this is the place - where do you update the message here for cancellation?
Line 1206:         except libvirt.libvirtError as e:
Line 1207:             if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID:
Line 1208:                 return errCode['migCancelErr']
Line 1209:             raise


--
To view, visit http://gerrit.ovirt.org/6824
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <evilissimo at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list