Change in vdsm[master]: Simplify netinfo get.

asegurap at redhat.com asegurap at redhat.com
Fri Jan 18 13:54:54 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Simplify netinfo get.
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File vdsm/netinfo.py
Line 273:                 paddr[slave] = addr.upper()
Line 274:     return paddr
Line 275: 
Line 276: 
Line 277: def _getNetInfo(iface, bridged, routes):
I finally decided that I don't want to marry with the name as a public thing just yet. As there is too much refactoring going on. Thanks for the tip Dan.
Line 278:     '''Returns a dictionary of properties about the network's interface status.
Line 279:     Raises a KeyError if the iface does not exist.'''
Line 280:     data = {}
Line 281:     try:


--
To view, visit http://gerrit.ovirt.org/11080
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c3e617d10308d0bfa4deaed329b2e10ef54077c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list