Change in vdsm[master]: Remove innecessary netinfo instance creation.
asegurap at redhat.com
asegurap at redhat.com
Fri Jan 18 11:17:42 UTC 2013
Antoni Segura Puimedon has posted comments on this change.
Change subject: Remove innecessary netinfo instance creation.
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/netinfo.py
Line 520: try:
Line 521: self.bondings[bond] = getBondData(bond)
Line 522: except KeyError:
Line 523: if bond in self.bondings:
Line 524: del self.bondings[bond]
This one doesn't raise, in contrast to updateNetwork() because we want it to update all the bonds if called with several. I guess it could potentially check if len(bonds) is 1 and throw then, but I'm not convinced of the usefulness of that.
--
To view, visit http://gerrit.ovirt.org/11082
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cef02dc89d927799bf92d36b790598707583195
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list