Change in vdsm[master]: Simplify netinfo get.

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Fri Jan 18 02:19:00 UTC 2013


Mark Wu has posted comments on this change.

Change subject: Simplify netinfo get.
......................................................................


Patch Set 3: No score

(1 inline comment)

....................................................
File vdsm/netinfo.py
Line 292:         return data
Line 293:     except OSError as e:
Line 294:         if e.errno == errno.ENOENT:
Line 295:             logging.info('Obtaining info for net %s.', net, exc_info=True)
Line 296:             raise KeyError('Network %s was not found')
Now I see why you handle the exception here. I am fine with it.
Line 297:         else:
Line 298:             raise
Line 299: 
Line 300: 


--
To view, visit http://gerrit.ovirt.org/11080
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c3e617d10308d0bfa4deaed329b2e10ef54077c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list