Change in vdsm[master]: tests: Fix parted_utils_tests break on fedora 18

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Thu Jan 17 08:32:10 UTC 2013


Mark Wu has uploaded a new change for review.

Change subject: tests: Fix parted_utils_tests break on fedora 18
......................................................................

tests: Fix parted_utils_tests break on fedora 18

parted 3.1 improves its support for loopback devices. The 'model' string
returned by libparted is updated to 'Loopback device'. For more information,
please see:
http://anonscm.debian.org/gitweb/?p=parted/parted.git;a=commit;h=3e35b6

Because another bug of parted.version() on rhel6
(https://bugzilla.redhat.com/show_bug.cgi?format=multiple&id=700383),
we can't use parted.version() to differentiate the parted version.
We could restort to rpm db, but loop device is only used in test code,
so it should be safe to ignore the test of model string.

Change-Id: Ia144353747f9343689a8c105ccf3c7fe691de31e
Signed-off-by: Mark Wu <wudxw at linux.vnet.ibm.com>
---
M tests/parted_utils_tests.py
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/11137/1

diff --git a/tests/parted_utils_tests.py b/tests/parted_utils_tests.py
index 808d748..ce413d7 100644
--- a/tests/parted_utils_tests.py
+++ b/tests/parted_utils_tests.py
@@ -79,7 +79,6 @@
 
     def _blank_dev_test(self):
         info = putils.getDevicePartedInfo(self.devPath)
-        self.assertFalse(info['model'])
         self.assertTrue(info['sectorSize'] >= 0)
         self.assertFalse(info['type'])
         self.assertFalse(info['partitions'])
@@ -99,7 +98,6 @@
         time.sleep(1)  # wait for syncing
 
         info = putils.getDevicePartedInfo(self.devPath)
-        self.assertFalse(info['model'])
         self.assertTrue(info['sectorSize'] >= 0)
         self.assertEquals(info['type'], 'gpt')
         self.assertTrue(info['freeSpaceRegions'][0][3] >= FREE_SIZE)


--
To view, visit http://gerrit.ovirt.org/11137
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia144353747f9343689a8c105ccf3c7fe691de31e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list