Change in vdsm[master]: Remove redundant exception assignations.

asegurap at redhat.com asegurap at redhat.com
Wed Jan 16 09:46:55 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Remove redundant exception assignations.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/image.py
Line 940:                     if rc:
Line 941:                         raise se.StorageException("rc: %s, err: %s" %
Line 942:                                                   (rc, err))
Line 943:                 except se.ActionStopped:
Line 944:                     raise
Totally right... I'm thinking if I should not take the opportunity for removing the whole clause right now.
Line 945:                 except se.StorageException as e:
Line 946:                     raise se.CopyImageError(str(e))
Line 947: 
Line 948:                 # Mark volume as SHARED


--
To view, visit http://gerrit.ovirt.org/11034
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5521612493ee9d5a57816fbcd8a54b174d29aefb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list