Change in vdsm[master]: remove redundant libvirt call

peet at redhat.com peet at redhat.com
Tue Jan 15 15:51:19 UTC 2013


Peter V. Saveliev has uploaded a new change for review.

Change subject: remove redundant libvirt call
......................................................................

remove redundant libvirt call

Checking UUIDString() adresses the bug #603494, which
is closed ages ago. While it is nice to support really
ancient libvirt versions, it costs us one extra
libvirt call. Given global libvirt driver lock, it
does matter in mass VM creation.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=603494
Signed-off-by: Peter V. Saveliev <peet at redhat.com>
Change-Id: I06a71c2e44332f50b3203a0a8f1bfa799914b684
---
M vdsm/libvirtvm.py
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/11054/1

diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index d13dbb0..9376e5c 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -1539,8 +1539,6 @@
             self._dom = NotifyingVirDomain(
                 self._connection.createXML(domxml, flags),
                 self._timeoutExperienced)
-            if self._dom.UUIDString() != self.id:
-                raise Exception('libvirt bug 603494')
             hooks.after_vm_start(self._dom.XMLDesc(0), self.conf)
         if not self._dom:
             self.setDownStatus(ERROR, 'failed to start libvirt vm')


--
To view, visit http://gerrit.ovirt.org/11054
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I06a71c2e44332f50b3203a0a8f1bfa799914b684
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>


More information about the vdsm-patches mailing list