Change in vdsm[master]: Support for GLUSTERFS_DOMAIN

deepakcs at linux.vnet.ibm.com deepakcs at linux.vnet.ibm.com
Tue Jan 15 09:52:15 UTC 2013


Deepak C Shetty has posted comments on this change.

Change subject: Support for GLUSTERFS_DOMAIN
......................................................................


Patch Set 13: (1 inline comment)

....................................................
File vdsm/storage/glusterSD.py
Line 18:         return glusterVolume.GlusterVolume
Line 19: 
Line 20:     @staticmethod
Line 21:     def findDomainPath(sdUUID):
Line 22:         glusterDomPath = os.path.join(sd.GLUSTERSD_DIR + "/*")
I had tried the below...

os.path.join(sd.GLUSTERSD_DIR, "*") 
and that was not working. After debug i found it was giving glusterSD* not glusterSD/*
which was causing my findDomain to fail.

Hence i used os.path.join(sd.GLUSTERSD_DIR, "/*")
Line 23:         for tmpSdUUID, domainPath in fileSD.scanDomains(glusterDomPath):
Line 24:             if tmpSdUUID == sdUUID and mount.isMounted(os.path.join(domainPath,
Line 25:                                                        "..")):
Line 26:                 return domainPath


--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list