Change in vdsm[master]: Support for GLUSTERFS_DOMAIN

deepakcs at linux.vnet.ibm.com deepakcs at linux.vnet.ibm.com
Mon Jan 14 09:50:52 UTC 2013


Deepak C Shetty has posted comments on this change.

Change subject: Support for GLUSTERFS_DOMAIN
......................................................................


Patch Set 12: (1 inline comment)

....................................................
File vdsm/storage/volume.py
Line 868:         volume to the VM in a different way than the standard 'path' way.
Line 869:         """
Line 870:         # By default, send path
Line 871:         return {'volType': VmVolumeInfo.TYPE_PATH,
Line 872:                 'path': self.getVolumePath()}
Another reason, I was also not sure if in future consumers of prepareImage might still expect ['path'] to be the path in the domain. if we remove that, derived class might change vmVolInfo['path'] and that can break assumptions of prepareImage consumers. To be safe for past and future users, and for reasons mentioned above, i still feel path is needed in both places.
Line 873: 
Line 874:     def getMetaParam(self, key):
Line 875:         """
Line 876:         Get a value of a specific key


--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list