Change in vdsm[master]: Don't crash on libvirt network re-definition.
wudxw at linux.vnet.ibm.com
wudxw at linux.vnet.ibm.com
Mon Jan 14 05:09:25 UTC 2013
Mark Wu has posted comments on this change.
Change subject: Don't crash on libvirt network re-definition.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 212: if netName not in conn.listNetworks():
Line 213: raise
Line 214: net = conn.networkLookupByName(netName)
Line 215: if bridged:
Line 216: if net.bridgeName() != network:
How about just deleting the old libvirt network unconditionally if there's a network with the same name, and then create the new network again.
Line 217: raise
Line 218: else:
Line 219: if parseString(net.XMLDesc(0)).\
Line 220: getElementsByTagName('interface')[0].\
--
To view, visit http://gerrit.ovirt.org/10901
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d95e20b7aa99280e604abdb1663c6c5c7dd32e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list